Hacktoberfest: Second Pull Request - wanikani-notifier

-

 This post describes the journey of the second pull request for Hacktoberfest which encourages new people to get involved in the open-source community. The post for the first pull request for Hacktoberfest is the following: https://hyunjijanelee.blogspot.com/2020/10/hacktoberfest-first-pull-request-tower.html

In this time, I have struggled to find an issue to work on. Most of the issues I would like to work on are already taken to another person and other issues have some problems on the project so I cannot run it properly. I kept finding a proper project and found one project named wanikani-notifier. The link for the wanikani-notifier is the following: https://github.com/upsetdog/wanikani-notifier

When I found an issue with this project, I cloned the project to check whether I can run this project. At that time, I found it has another issue to make it better. On this project, there is no 'package-lock.json' file so users need to install modules checking what modules are needed for this project. It would be much better if this project has package-lock.json file so users can simply install modules when they enter 'npm install'. Therefore, I filed an issue to ask whether I can do this task. The link for the issue is the following: https://github.com/upsetdog/wanikani-notifier/issues/9. The owner of this project assigned me to this task so I started working on it.

I've installed modules to create package-lock.json file. Also, I've updated README.md file so users can follow the step to build this project. The first code below is the step before and the second one is the step I've updated.

- The previous installation process

Clone the repository, install the required packages, and run node index.js it'll run until you cancel it. replace "YOUR TOKEN HERE" with your wanikani api v2 token, in the config.json file

- The updated installation process

1. Clone the repository
2. Install the required packages entering 'npm install'
3. Replace "YOUR TOKEN HERE" in the config.json file with your wanikani  api v2 token
4. Run node index.js it'll run until you cancel it

I've added my changes and created a pull request for this issue. Currently, I am waiting for reviewing. The link to my pull request is the following: https://github.com/upsetdog/wanikani-notifier/pull/10

Finding an issue to work on takes most of the time for this pull request. I've learned it would be better to find an issue as fast as possible. Also, I realized I had so much fun finding another issue has not been filed yet and fixing the issue. It was a really good practice.

Comments

Post a Comment

Popular posts from this blog

Release 4.0 - Part 3: Release

-
In this post, I am going to describe the journey of the release 4.0. Release 4.0 is the 3 weeks project. In the first week, I chose the project to work on. As the issue I chose required knowledge I do not have any idea (Gatsby and Nextjs), I need to learn these. In the second week, I learned the Gatsby and Nextjs to read the document on the Next official website. Also, I checked the pull request other people already created for the project. And this week, I started writing codes to resolve the issue. It was hard to begin to migrate the pages from Gatsby to the Nextjs. I needed to google a lot to find the proper way to migrate the code for the project. The components I was assigned are Error page, SEO, and SearchHelp components. The SEO component is relatively easy because the Next official website indicated how to do it most. However, the Error page is the most difficult part for me. When I googled how to make the Nextjs Errorpage, most people recommend to use the JavaScript extension ...
Read more

Open Source Project: Lab2 (Pull Request)

-
Image
 Introduction In this lab, I practiced contributing and submitting pull requests to other repositories I don't own. Following the lab instruction , the things I plan to practice are the following: forking and cloning other projects creating branches to work on new features and fix bugs working on code I didn't write, trying to maintain the original style and not break things creating pull requests collaborating with other developers on GitHub updating my pull requests to include fixes for review comments The Project I picked for pull request ( https://github.com/lixiaoqity/testLink/pull/7 ) I looked around the classmates' open source project and picked the project named testLink. The GitHub repository link is the following:  https://github.com/lixiaoqity/testLink/pull/7 .  I picked this project because it also uses the NodeJS which I picked for my project. It was really interesting to see how code can be written differently for the same subject. When I look over the proje...
Read more